linux-kernel - Re: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jan 2022 09:40:42 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Marcel Ziswiler <marcel@...wiler.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Marek Vasut <marek.vasut@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Arnd Bergmann <arnd@...db.de>,
        Biju Das <biju.das.jz@...renesas.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Guido Günther <agx@...xcpu.org>,
        Olof Johansson <olof@...om.net>,
        Shawn Guo <shawnguo@...nel.org>, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module

On 07/01/2022 19:03, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Build Realtek Gigabit Ethernet driver as a module.

Why?

We see what the patch does easily, so no really need of explaining it.
What is needed here is to explain why do you do it? What board needs it?

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> ---
> 
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a18785a827dc..86d39d8456c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -338,6 +338,7 @@ CONFIG_MLX5_CORE=m
>  CONFIG_MLX5_CORE_EN=y
>  CONFIG_QCOM_EMAC=m
>  CONFIG_RMNET=m
> +CONFIG_R8169=m
>  CONFIG_SH_ETH=y
>  CONFIG_RAVB=y
>  CONFIG_SMC91X=y
> 


Best regards,
Krzysztof