linux-kernel - Re: [PATCH 2/3] dt-bindings: Add dma-channels for pdma device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUyYVBXAeJ8XS9OsUePpFLgpCXYT5rH_bJCvCg3eaav_w@mail.gmail.com>
Date:   Mon, 10 Jan 2022 10:00:15 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Zong Li <zong.li@...ive.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Bin Meng <bin.meng@...driver.com>, green.wan@...ive.com,
        Vinod <vkoul@...nel.org>, dmaengine <dmaengine@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 2/3] dt-bindings: Add dma-channels for pdma device node

Hi Zong,

On Wed, Jan 5, 2022 at 6:44 AM Zong Li <zong.li@...ive.com> wrote:
> Add dma-channels property, then we can determine how many channels there
> by device tree, rather than statically defines it in PDMA driver
>
> Signed-off-by: Zong Li <zong.li@...ive.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> @@ -34,12 +34,17 @@ properties:
>      minItems: 1
>      maxItems: 8
>
> +  dma-channels:
> +    minimum: 1
> +    maximum: 4

As per my comment on [PATCH 3/3], perhaps you want to use a default
value of 4, and document that here, too?

> +
>    '#dma-cells':
>      const: 1
>
>  required:
>    - compatible
>    - reg
> +  - dma-channels
>    - interrupts
>    - '#dma-cells'
>


Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds