linux-kernel - Re: [PATCH 5.10 09/43] netrom: fix copying in user data in nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220110100708.GA5588@duo.ucw.cz>
Date:   Mon, 10 Jan 2022 11:07:08 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Christoph Hellwig <hch@....de>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5.10 09/43] netrom: fix copying in user data in
 nr_setsockopt

Hi!

> From: Christoph Hellwig <hch@....de>
> 
> commit 3087a6f36ee028ec095c04a8531d7d33899b7fed upstream.
> 
> This code used to copy in an unsigned long worth of data before
> the sockptr_t conversion, so restore that.

Maybe, but then	the size checks	need to	be updated, too.

> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  net/netrom/af_netrom.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/netrom/af_netrom.c
> +++ b/net/netrom/af_netrom.c
> @@ -306,7 +306,7 @@ static int nr_setsockopt(struct socket *
>  	if (optlen < sizeof(unsigned int))

This should   be   < sizeof(unsigned long)) ... AFAICT.

>  		return -EINVAL;
>  
> -	if (copy_from_sockptr(&opt, optval, sizeof(unsigned int)))
> +	if (copy_from_sockptr(&opt, optval, sizeof(unsigned long)))
>  		return -EFAULT;
>  

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)