| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jan 2022 18:19:19 +0800
From: kernel test robot <lkp@...el.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mingo-tip:master 2055/2375] arch/mips/sibyte/sb1250/irq.c:72:39:
warning: 'struct irq_data' declared inside parameter list will not be
visible outside of this definition or declaration
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git master
head: 391ce485ced0e47bf8d2ce8bc32bb87887e16656
commit: 78e95e8ad607924f6b933eedfb11d434e964e7d7 [2055/2375] headers/deps: genirq: Optimize <linux/interrupt.h> dependencies, remove <linux/hardirq.h>
config: mips-randconfig-r015-20220109 (https://download.01.org/0day-ci/archive/20220110/202201101851.9bCmTBYV-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=78e95e8ad607924f6b933eedfb11d434e964e7d7
git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
git fetch --no-tags mingo-tip master
git checkout 78e95e8ad607924f6b933eedfb11d434e964e7d7
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/sibyte/sb1250/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> arch/mips/sibyte/sb1250/irq.c:72:39: warning: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration
72 | static int sb1250_set_affinity(struct irq_data *d, const struct cpumask *mask,
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c: In function 'sb1250_set_affinity':
arch/mips/sibyte/sb1250/irq.c:76:29: error: invalid use of undefined type 'struct irq_data'
76 | unsigned int irq = d->irq;
| ^~
arch/mips/sibyte/sb1250/irq.c: At top level:
arch/mips/sibyte/sb1250/irq.c:114:39: warning: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration
114 | static void disable_sb1250_irq(struct irq_data *d)
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c: In function 'disable_sb1250_irq':
arch/mips/sibyte/sb1250/irq.c:116:29: error: invalid use of undefined type 'struct irq_data'
116 | unsigned int irq = d->irq;
| ^~
arch/mips/sibyte/sb1250/irq.c: At top level:
arch/mips/sibyte/sb1250/irq.c:121:38: warning: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration
121 | static void enable_sb1250_irq(struct irq_data *d)
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c: In function 'enable_sb1250_irq':
arch/mips/sibyte/sb1250/irq.c:123:29: error: invalid use of undefined type 'struct irq_data'
123 | unsigned int irq = d->irq;
| ^~
arch/mips/sibyte/sb1250/irq.c: At top level:
arch/mips/sibyte/sb1250/irq.c:129:35: warning: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration
129 | static void ack_sb1250_irq(struct irq_data *d)
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c: In function 'ack_sb1250_irq':
arch/mips/sibyte/sb1250/irq.c:131:29: error: invalid use of undefined type 'struct irq_data'
131 | unsigned int irq = d->irq;
| ^~
arch/mips/sibyte/sb1250/irq.c: At top level:
arch/mips/sibyte/sb1250/irq.c:174:15: error: variable 'sb1250_irq_type' has initializer but incomplete type
174 | static struct irq_chip sb1250_irq_type = {
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c:175:10: error: 'struct irq_chip' has no member named 'name'
175 | .name = "SB1250-IMR",
| ^~~~
>> arch/mips/sibyte/sb1250/irq.c:175:17: warning: excess elements in struct initializer
175 | .name = "SB1250-IMR",
| ^~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:175:17: note: (near initialization for 'sb1250_irq_type')
arch/mips/sibyte/sb1250/irq.c:176:10: error: 'struct irq_chip' has no member named 'irq_mask_ack'
176 | .irq_mask_ack = ack_sb1250_irq,
| ^~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:176:25: warning: excess elements in struct initializer
176 | .irq_mask_ack = ack_sb1250_irq,
| ^~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:176:25: note: (near initialization for 'sb1250_irq_type')
arch/mips/sibyte/sb1250/irq.c:177:10: error: 'struct irq_chip' has no member named 'irq_unmask'
177 | .irq_unmask = enable_sb1250_irq,
| ^~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:177:23: warning: excess elements in struct initializer
177 | .irq_unmask = enable_sb1250_irq,
| ^~~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:177:23: note: (near initialization for 'sb1250_irq_type')
arch/mips/sibyte/sb1250/irq.c:178:10: error: 'struct irq_chip' has no member named 'irq_mask'
178 | .irq_mask = disable_sb1250_irq,
| ^~~~~~~~
arch/mips/sibyte/sb1250/irq.c:178:21: warning: excess elements in struct initializer
178 | .irq_mask = disable_sb1250_irq,
| ^~~~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:178:21: note: (near initialization for 'sb1250_irq_type')
arch/mips/sibyte/sb1250/irq.c:180:10: error: 'struct irq_chip' has no member named 'irq_set_affinity'
180 | .irq_set_affinity = sb1250_set_affinity
| ^~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:180:29: warning: excess elements in struct initializer
180 | .irq_set_affinity = sb1250_set_affinity
| ^~~~~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:180:29: note: (near initialization for 'sb1250_irq_type')
arch/mips/sibyte/sb1250/irq.c:184:13: warning: no previous prototype for 'init_sb1250_irqs' [-Wmissing-prototypes]
184 | void __init init_sb1250_irqs(void)
| ^~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c: In function 'init_sb1250_irqs':
arch/mips/sibyte/sb1250/irq.c:189:17: error: implicit declaration of function 'irq_set_chip_and_handler' [-Werror=implicit-function-declaration]
189 | irq_set_chip_and_handler(i, &sb1250_irq_type,
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:190:42: error: 'handle_level_irq' undeclared (first use in this function)
190 | handle_level_irq);
| ^~~~~~~~~~~~~~~~
arch/mips/sibyte/sb1250/irq.c:190:42: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/sibyte/sb1250/irq.c: At top level:
arch/mips/sibyte/sb1250/irq.c:174:24: error: storage size of 'sb1250_irq_type' isn't known
174 | static struct irq_chip sb1250_irq_type = {
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +72 arch/mips/sibyte/sb1250/irq.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 70
^1da177e4c3f41 Linus Torvalds 2005-04-16 71 #ifdef CONFIG_SMP
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 @72 static int sb1250_set_affinity(struct irq_data *d, const struct cpumask *mask,
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 73 bool force)
^1da177e4c3f41 Linus Torvalds 2005-04-16 74 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 75 int i = 0, old_cpu, cpu, int_on;
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 76 unsigned int irq = d->irq;
^1da177e4c3f41 Linus Torvalds 2005-04-16 77 u64 cur_ints;
^1da177e4c3f41 Linus Torvalds 2005-04-16 78 unsigned long flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 79
421d1563c66204 Thomas Gleixner 2014-03-04 80 i = cpumask_first_and(mask, cpu_online_mask);
^1da177e4c3f41 Linus Torvalds 2005-04-16 81
^1da177e4c3f41 Linus Torvalds 2005-04-16 82 /* Convert logical CPU to physical CPU */
^1da177e4c3f41 Linus Torvalds 2005-04-16 83 cpu = cpu_logical_map(i);
^1da177e4c3f41 Linus Torvalds 2005-04-16 84
^1da177e4c3f41 Linus Torvalds 2005-04-16 85 /* Protect against other affinity changers and IMR manipulation */
5772f6deb6214a Ralf Baechle 2010-02-27 86 raw_spin_lock_irqsave(&sb1250_imr_lock, flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16 87
^1da177e4c3f41 Linus Torvalds 2005-04-16 88 /* Swizzle each CPU's IMR (but leave the IP selection alone) */
^1da177e4c3f41 Linus Torvalds 2005-04-16 89 old_cpu = sb1250_irq_owner[irq];
65bda1a95d395c Maciej W. Rozycki 2005-02-22 90 cur_ints = ____raw_readq(IOADDR(A_IMR_MAPPER(old_cpu) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 91 R_IMR_INTERRUPT_MASK));
^1da177e4c3f41 Linus Torvalds 2005-04-16 92 int_on = !(cur_ints & (((u64) 1) << irq));
^1da177e4c3f41 Linus Torvalds 2005-04-16 93 if (int_on) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 94 /* If it was on, mask it */
^1da177e4c3f41 Linus Torvalds 2005-04-16 95 cur_ints |= (((u64) 1) << irq);
65bda1a95d395c Maciej W. Rozycki 2005-02-22 96 ____raw_writeq(cur_ints, IOADDR(A_IMR_MAPPER(old_cpu) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 97 R_IMR_INTERRUPT_MASK));
^1da177e4c3f41 Linus Torvalds 2005-04-16 98 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 99 sb1250_irq_owner[irq] = cpu;
^1da177e4c3f41 Linus Torvalds 2005-04-16 100 if (int_on) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 101 /* unmask for the new CPU */
65bda1a95d395c Maciej W. Rozycki 2005-02-22 102 cur_ints = ____raw_readq(IOADDR(A_IMR_MAPPER(cpu) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 103 R_IMR_INTERRUPT_MASK));
^1da177e4c3f41 Linus Torvalds 2005-04-16 104 cur_ints &= ~(((u64) 1) << irq);
65bda1a95d395c Maciej W. Rozycki 2005-02-22 105 ____raw_writeq(cur_ints, IOADDR(A_IMR_MAPPER(cpu) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 106 R_IMR_INTERRUPT_MASK));
^1da177e4c3f41 Linus Torvalds 2005-04-16 107 }
5772f6deb6214a Ralf Baechle 2010-02-27 108 raw_spin_unlock_irqrestore(&sb1250_imr_lock, flags);
d5dedd4507d307 Yinghai Lu 2009-04-27 109
d5dedd4507d307 Yinghai Lu 2009-04-27 110 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 111 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 112 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 113
1544129da2de9f Thomas Gleixner 2011-06-06 114 static void disable_sb1250_irq(struct irq_data *d)
1544129da2de9f Thomas Gleixner 2011-06-06 115 {
1544129da2de9f Thomas Gleixner 2011-06-06 116 unsigned int irq = d->irq;
1544129da2de9f Thomas Gleixner 2011-06-06 117
1544129da2de9f Thomas Gleixner 2011-06-06 118 sb1250_mask_irq(sb1250_irq_owner[irq], irq);
1544129da2de9f Thomas Gleixner 2011-06-06 119 }
1544129da2de9f Thomas Gleixner 2011-06-06 120
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 121 static void enable_sb1250_irq(struct irq_data *d)
^1da177e4c3f41 Linus Torvalds 2005-04-16 122 {
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 123 unsigned int irq = d->irq;
^1da177e4c3f41 Linus Torvalds 2005-04-16 124
^1da177e4c3f41 Linus Torvalds 2005-04-16 125 sb1250_unmask_irq(sb1250_irq_owner[irq], irq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 126 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 127
^1da177e4c3f41 Linus Torvalds 2005-04-16 128
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 129 static void ack_sb1250_irq(struct irq_data *d)
^1da177e4c3f41 Linus Torvalds 2005-04-16 130 {
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 131 unsigned int irq = d->irq;
^1da177e4c3f41 Linus Torvalds 2005-04-16 132 #ifdef CONFIG_SIBYTE_HAS_LDT
^1da177e4c3f41 Linus Torvalds 2005-04-16 133 u64 pending;
^1da177e4c3f41 Linus Torvalds 2005-04-16 134
^1da177e4c3f41 Linus Torvalds 2005-04-16 135 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 136 * If the interrupt was an HT interrupt, now is the time to
^1da177e4c3f41 Linus Torvalds 2005-04-16 137 * clear it. NOTE: we assume the HT bridge was set up to
^1da177e4c3f41 Linus Torvalds 2005-04-16 138 * deliver the interrupts to all CPUs (which makes affinity
^1da177e4c3f41 Linus Torvalds 2005-04-16 139 * changing easier for us)
^1da177e4c3f41 Linus Torvalds 2005-04-16 140 */
65bda1a95d395c Maciej W. Rozycki 2005-02-22 141 pending = __raw_readq(IOADDR(A_IMR_REGISTER(sb1250_irq_owner[irq],
^1da177e4c3f41 Linus Torvalds 2005-04-16 142 R_IMR_LDT_INTERRUPT)));
^1da177e4c3f41 Linus Torvalds 2005-04-16 143 pending &= ((u64)1 << (irq));
^1da177e4c3f41 Linus Torvalds 2005-04-16 144 if (pending) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 145 int i;
^1da177e4c3f41 Linus Torvalds 2005-04-16 146 for (i=0; i<NR_CPUS; i++) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 147 int cpu;
^1da177e4c3f41 Linus Torvalds 2005-04-16 148 #ifdef CONFIG_SMP
^1da177e4c3f41 Linus Torvalds 2005-04-16 149 cpu = cpu_logical_map(i);
^1da177e4c3f41 Linus Torvalds 2005-04-16 150 #else
^1da177e4c3f41 Linus Torvalds 2005-04-16 151 cpu = i;
^1da177e4c3f41 Linus Torvalds 2005-04-16 152 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 153 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 154 * Clear for all CPUs so an affinity switch
^1da177e4c3f41 Linus Torvalds 2005-04-16 155 * doesn't find an old status
^1da177e4c3f41 Linus Torvalds 2005-04-16 156 */
65bda1a95d395c Maciej W. Rozycki 2005-02-22 157 __raw_writeq(pending,
^1da177e4c3f41 Linus Torvalds 2005-04-16 158 IOADDR(A_IMR_REGISTER(cpu,
^1da177e4c3f41 Linus Torvalds 2005-04-16 159 R_IMR_LDT_INTERRUPT_CLR)));
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 161
^1da177e4c3f41 Linus Torvalds 2005-04-16 162 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * Generate EOI. For Pass 1 parts, EOI is a nop. For
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 * Pass 2, the LDT world may be edge-triggered, but
^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * this EOI shouldn't hurt. If they are
^1da177e4c3f41 Linus Torvalds 2005-04-16 166 * level-sensitive, the EOI is required.
^1da177e4c3f41 Linus Torvalds 2005-04-16 167 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 168 *(uint32_t *)(ldt_eoi_space+(irq<<16)+(7<<2)) = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 169 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 170 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 171 sb1250_mask_irq(sb1250_irq_owner[irq], irq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 172 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 173
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 174 static struct irq_chip sb1250_irq_type = {
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 @175 .name = "SB1250-IMR",
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 176 .irq_mask_ack = ack_sb1250_irq,
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 177 .irq_unmask = enable_sb1250_irq,
1544129da2de9f Thomas Gleixner 2011-06-06 178 .irq_mask = disable_sb1250_irq,
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 179 #ifdef CONFIG_SMP
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 180 .irq_set_affinity = sb1250_set_affinity
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 181 #endif
d6d5d5c4afd4c8 Thomas Gleixner 2011-03-23 182 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 183
:::::: The code at line 72 was first introduced by commit
:::::: d6d5d5c4afd4c8bb4c5e3753a2141e9c3a874629 MIPS: Sibyte: Convert to new irq_chip functions
:::::: TO: Thomas Gleixner <tglx@...utronix.de>
:::::: CC: Ralf Baechle <ralf@...ux-mips.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists