linux-kernel - Re: [PATCH v1 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdwwKXrw+qICwIaW@pendragon.ideasonboard.com>
Date:   Mon, 10 Jan 2022 15:10:02 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     mchehab@...nel.org, robh@...nel.org, sakari.ailus@...ux.intel.com,
        geert@...ux-m68k.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: media: hynix,hi846: use
 $defs/port-base port description

Hi Martin,

Thank you for the patch.

On Mon, Jan 10, 2022 at 01:38:03PM +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
>     From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> 
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> ---
> 
> Link:
> https://lore.kernel.org/linux-media/CAL_JsqKzaZC0A4OwnMyAuEWm2pCcHyQxHyrBVtkiPNUeMDd+oA@mail.gmail.com/
> 
>  Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 85a8877c2f38..e61255cf3fb9 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -49,7 +49,7 @@ properties:
>      description: Definition of the regulator used for the VDDD power supply.
>  
>    port:
> -    $ref: /schemas/graph.yaml#/properties/port
> +    $ref: /schemas/graph.yaml#/$defs/port-base

You also need to add

    unevaluatedProperties: false

to reject any property that isn't defined in either port-base or in this
schema. Otherwise any extra property in the port node will be accepted.

>  
>      properties:
>        endpoint:

-- 
Regards,

Laurent Pinchart