linux-kernel - Re: PATCH v4 ASUS EC Sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0uakBuv1oBXoq7hUQxghKrFabqWebbG437WBNMuBVpYRL4vCE-IxwsbH16I82L-hq4xLtuSvBM1UaPfUy1HxmoFJYFHkDuJPxh3dZ_P8LuM=@protonmail.com>
Date:   Tue, 11 Jan 2022 18:16:57 +0000
From:   Barnabás Pőcze <pobrn@...tonmail.com>
To:     Eugene Shalygin <eugene.shalygin@...il.com>
Cc:     andy.shevchenko@...il.com, pauk.denis@...il.com,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: PATCH v4 ASUS EC Sensors

2022. január 11., kedd 19:03 keltezéssel, Eugene Shalygin írta:

> This patchset replaces the HWMON asus_wmi_ec_sensors driver with
> an implementation that does not use WMI but queries the embedded
> controller directly.
>
> That provides two enhancements: sensor reading became quicker (on some
> systems or kernel configuration it took almost a full second to read
> all the sensors, that transfers less than 15 bytes of data), the driver
> became more fexible. The driver now relies on ACPI mutex to lock access
> to the EC, in the same way as the WMI DSDT code does.
>
> Chenges in v5:
>  - Place the sensors bitset directly into the driver_data field of the
> 	 dmi_system_id struct.
>  - Replace doc comments with regular ones.
>
> Changes in v4:
>  - Deprecate the wmi driver rather than removing it.
>
> Changes in v3:
>  - Remove BIOS version checks and BIOS version dependent mutex path.
>
> Changes in v2:
>  - Replace sensor flags enum with bitset
>  - Replace module init/probe functions with module_platform_driver_probe
>    and ask the platform drivers framework to load the driver when ACPI
>    EC is found (ACPI ID "PNP0C09").
>  - Extend board data with BIOS version attribute for the mutex path to be
>    BIOS version dependent.
>  - Add module parameter to override the mutex path.
>

Hi


I believe the subject should say "v5" and not "v4". In any case, FYI, `git format-patch`
has the `--cover-letter` option, which will generate a cover letter template
with the right patch version, etc.


Regards,
Barnabás Pőcze