linux-kernel - Re: [PATCH v3] ide: Check for null pointer after calling devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220111022328.ynoyoekjwwf6p2vw@naota-xeon>
Date:   Tue, 11 Jan 2022 02:23:29 +0000
From:   Naohiro Aota <Naohiro.Aota@....com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
CC:     "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "David.Laight@...LAB.COM" <David.Laight@...LAB.COM>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

On Sun, Jan 09, 2022 at 10:01:42PM +0800, Jiasheng Jiang wrote:
> On Sun, Jan 09, 2022 at 04:53:39PM +0800, Damien Le Moal wrote:
> >>>> Cc: stable@...r.kernel.org#5.10
> >>>
> >>> Please keep the space before the #
> >>>
> >>> Cc: stable@...r.kernel.org #5.10
> >> 
> >> Actually, I added the space before, but the when I use the tool
> >> 'scripts/checkpatch.pl' to check my format, it told me a warning
> >> that it should not have space.
> >> 
> >> The warning is as follow:
> >> WARNING: email address 'stable@...r.kernel.org #5.10' might be
> >> better as 'stable@...r.kernel.org#5.10'
> >
> > Cc: stable@...r.kernel.org # 5.10
> >
> > Should work.
> 
> I used 'scripts/checkpatch.pl' to check it, giving me the warning again.
> 
> The warning is as follow:
> WARNING: email address 'stable@...r.kernel.org # 5.10' might be better as
> 'stable@...r.kernel.org# 5.10'
> 
> And if I use the 'stable@...r.kernel.org# 5.10', warning too.
> 
> The warning is as follow:
> WARNING: email address 'stable@...r.kernel.org# 5.10' might be better as
> 'stable@...r.kernel.org#5.10' 
> 
> It seems that the only non-warning format is 'stable@...r.kernel.org#5.10'.
> 
> Sincerely thanks,
> Jiang
> 

The checkpatch.pl in 5.10.90 fails to parse the line as shown
above. That is fixed in commit fccaebf00e60 ("checkpatch: improve
email parsing") in the current tree.