[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87zgo128x0.fsf@mpe.ellerman.id.au>
Date: Wed, 12 Jan 2022 09:40:27 +1100
From: Michael Ellerman <michaele@....ibm.com>
To: Tyrel Datwyler <tyreld@...ux.ibm.com>,
Laurent Dufour <ldufour@...ux.ibm.com>,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc: Nathan Lynch <nathanl@...ux.ibm.com>
Subject: Re: [PATCH v5] powerpc/pseries: read the lpar name from the firmware
Tyrel Datwyler <tyreld@...ux.ibm.com> writes:
> On 1/6/22 8:13 AM, Laurent Dufour wrote:
>> The LPAR name may be changed after the LPAR has been started in the HMC.
>> In that case lparstat command is not reporting the updated value because it
>> reads it from the device tree which is read at boot time.
>>
>> However this value could be read from RTAS.
>>
>> Adding this value in the /proc/powerpc/lparcfg output allows to read the
>> updated value.
>>
>> However the hypervisor, like Qemu/KVM, may not support this RTAS
>> parameter. In that case the value reported in lparcfg is read from the
>> device tree and so is not updated accordingly.
>>
>> Cc: Nathan Lynch <nathanl@...ux.ibm.com>
>> Signed-off-by: Laurent Dufour <ldufour@...ux.ibm.com>
>
> My only nit would be that in general for consistency with other function names
> _RTAS_ and _DT_ should be lowercase. Seeing as they are statically scoped within
> lparcfg.c maybe its ok. Otherwise,
Yeah I agree, I changed them to lower case when applying.
cheers
Powered by blists - more mailing lists