linux-kernel - Re: [PATCH 2/6] KVM: x86: Use kvm_x86_ops in kvm_arch_check_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220111030626.GA2175@gao-cwp>
Date:   Tue, 11 Jan 2022 11:06:28 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     kvm@...r.kernel.org, pbonzini@...hat.com, kevin.tian@...el.com,
        tglx@...utronix.de, Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] KVM: x86: Use kvm_x86_ops in
 kvm_arch_check_processor_compat

On Mon, Jan 10, 2022 at 09:10:10PM +0000, Sean Christopherson wrote:
>On Mon, Dec 27, 2021, Chao Gao wrote:
>> check_processor_compatibility() is a "runtime" ops now. Use
>> kvm_x86_ops directly such that kvm_arch_check_processor_compat
>> can be called at runtime.
>> 
>> Signed-off-by: Chao Gao <chao.gao@...el.com>
>> ---
>>  arch/x86/kvm/x86.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 6411417b6871..770b68e72391 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -11383,7 +11383,6 @@ void kvm_arch_hardware_unsetup(void)
>>  int kvm_arch_check_processor_compat(void *opaque)
>>  {
>>  	struct cpuinfo_x86 *c = &cpu_data(smp_processor_id());
>> -	struct kvm_x86_init_ops *ops = opaque;
>>  
>>  	WARN_ON(!irqs_disabled());
>>  
>> @@ -11391,7 +11390,7 @@ int kvm_arch_check_processor_compat(void *opaque)
>>  	    __cr4_reserved_bits(cpu_has, &boot_cpu_data))
>>  		return -EIO;
>>  
>> -	return ops->runtime_ops->check_processor_compatibility();
>> +	return kvm_x86_ops.check_processor_compatibility();
>
>I'd just squash this with patch 01.  And might as well make this a static_call().

Will do