linux-kernel - RE: [PATCH] tty: serial: fsl_lpuart: count tty buffer overruns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jan 2022 08:06:44 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] tty: serial: fsl_lpuart: count tty buffer overruns

Hi Jiri,


> > Added support for counting the tty buffer overruns in fsl_lpuart
> > driver like other uart drivers.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >   drivers/tty/serial/fsl_lpuart.c | 19 +++++++++++++------
> >   1 file changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c index ce3e26144689..1e6f924d8507
> > 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> ...
> > @@ -1117,6 +1119,7 @@ static void lpuart_copy_rx_to_tty(struct
> lpuart_port *sport)
> >   	struct circ_buf *ring = &sport->rx_ring;
> >   	unsigned long flags;
> >   	int count = 0;
> > +	unsigned int copied = 0;
> >
> >   	if (lpuart_is_32(sport)) {
> >   		unsigned long sr = lpuart32_read(&sport->port, UARTSTAT);
> @@
> > -1218,20 +1221,24 @@ static void lpuart_copy_rx_to_tty(struct lpuart_port
> *sport)
> >   	if (ring->head < ring->tail) {
> >   		count = sport->rx_sgl.length - ring->tail;
> >
> > -		tty_insert_flip_string(port, ring->buf + ring->tail, count);
> > +		copied = tty_insert_flip_string(port, ring->buf + ring->tail,
> count);
> > +		if (copied != count)
> 
> Overall looks good, except tty_insert_flip_string returns an int and count is
> also an int. Wouldn't it be more consistent to declare copied as int too? This
> comparison would be without implicit conversion then.

Sure, that's reasonable, I will change it to int type in the V2 patch. Thanks!

Best regards
Sherry