lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jan 2022 16:51:04 -0800 From: Doug Anderson <dianders@...omium.org> To: Abhishek Kumar <kuabhs@...omium.org> Cc: Kalle Valo <kvalo@...eaurora.org>, ath10k <ath10k@...ts.infradead.org>, Rakesh Pillai <pillair@...eaurora.org>, linux-wireless <linux-wireless@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2 1/2] ath10k: search for default BDF name provided in DT Hi, On Mon, Jan 10, 2022 at 3:15 PM Abhishek Kumar <kuabhs@...omium.org> wrote: > > +int ath10k_core_parse_default_bdf_dt(struct ath10k *ar) > +{ > + struct device_node *node; > + const char *board_name = NULL; > + > + ar->id.default_bdf[0] = '\0'; > + > + node = ar->dev->of_node; > + if (!node) > + return -ENOENT; > + > + of_property_read_string(node, "qcom,ath10k-default-bdf", > + &board_name); > + if (!board_name) > + return -ENODATA; > + > + if (strscpy(ar->id.default_bdf, > + board_name, sizeof(ar->id.default_bdf)) < 0) > + ath10k_warn(ar, > + "default board name is longer than allocated buffer, board_name: %s; allocated size: %ld\n", > + board_name, sizeof(ar->id.default_bdf)); I suspect, but don't know for sure, that you're going to get another builder splat here. Just like sizeof() isn't guaranteed to return an "unsigned int", it's also not guaranteed to return an "unsigned long". I believe you want %zu. See Documentation/core-api/printk-formats.rst > + > + return 0; > +} > +EXPORT_SYMBOL(ath10k_core_parse_default_bdf_dt); Boy, that function seems like overkill for something that you need once at init time. ...and I also suspect that the lifetime of the string returned by of_property_read_string() is valid for as long as your "of_node" is held and thus probably you could use it directly (it likely has a longer lifetime than the location you're storing it). ...but I guess it matches the ath10k_core_check_dt() function above it, so I guess it's fine? -Doug
Powered by blists - more mailing lists