linux-kernel - [PATCH v6 2/3] phy: amlogic: meson8b-usb2: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220111095255.176141-3-aouledameur@baylibre.com>
Date:   Tue, 11 Jan 2022 10:52:54 +0100
From:   Amjad Ouled-Ameur <aouledameur@...libre.com>
To:     kishon@...com
Cc:     Amjad Ouled-Ameur <aouledameur@...libre.com>,
        p.zabel@...gutronix.de, balbi@...nel.org, jbrunet@...libre.com,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, khilman@...libre.com,
        linux-phy@...ts.infradead.org, vkoul@...nel.org,
        martin.blumenstingl@...glemail.com,
        Neil Armstrong <narmstrong@...libre.com>
Subject: [PATCH v6 2/3] phy: amlogic: meson8b-usb2: Use dev_err_probe()

Use the existing dev_err_probe() helper instead of open-coding the same
operation.

Signed-off-by: Amjad Ouled-Ameur <aouledameur@...libre.com>
Reported-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Acked-by: Neil Armstrong <narmstrong@...libre.com>
---
 drivers/phy/amlogic/phy-meson8b-usb2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c
index cf10bed40528..77e7e9b1428c 100644
--- a/drivers/phy/amlogic/phy-meson8b-usb2.c
+++ b/drivers/phy/amlogic/phy-meson8b-usb2.c
@@ -265,8 +265,9 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
 		return PTR_ERR(priv->clk_usb);
 
 	priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
-	if (PTR_ERR(priv->reset) == -EPROBE_DEFER)
-		return PTR_ERR(priv->reset);
+	if (IS_ERR(priv->reset))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset),
+				     "Failed to get the reset line");
 
 	priv->dr_mode = of_usb_get_dr_mode_by_phy(pdev->dev.of_node, -1);
 	if (priv->dr_mode == USB_DR_MODE_UNKNOWN) {
-- 
2.25.1