linux-kernel - Re: [PATCH v9 04/15] iommu/mediatek: Add probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaf59017-49d2-6579-a106-44bd2a21e5af@collabora.com>
Date:   Tue, 11 Jan 2022 11:57:48 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Yong Wu <yong.wu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Joerg Roedel <joro@...tes.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        David Airlie <airlied@...ux.ie>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Will Deacon <will.deacon@....com>,
        dri-devel@...ts.freedesktop.org, yf.wang@...iatek.com,
        anthony.huang@...iatek.com, youlin.pei@...iatek.com,
        Evan Green <evgreen@...omium.org>,
        Eizan Miyamoto <eizan@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        linux-arm-kernel@...ts.infradead.org, mingyuan.ma@...iatek.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>, libo.kang@...iatek.com,
        yi.kuo@...iatek.com, linux-mediatek@...ts.infradead.org,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Tiffany Lin <tiffany.lin@...iatek.com>, anan.sun@...iatek.com,
        srv_heupstream@...iatek.com, acourbot@...omium.org,
        linux-kernel@...r.kernel.org, Tomasz Figa <tfiga@...omium.org>,
        iommu@...ts.linux-foundation.org, Daniel Vetter <daniel@...ll.ch>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v9 04/15] iommu/mediatek: Add probe_defer for smi-larb

Il 12/11/21 11:54, Yong Wu ha scritto:
> Prepare for adding device_link.
> 
> The iommu consumer should use device_link to connect with the
> smi-larb(supplier). then the smi-larb should run before the iommu
> consumer. Here we delay the iommu driver until the smi driver is ready,
> then all the iommu consumers always are after the smi driver.
> 
> When there is no this patch, if some consumer drivers run before
> smi-larb, the supplier link_status is DL_DEV_NO_DRIVER(0) in the
> device_link_add, then device_links_driver_bound will use WARN_ON
> to complain that the link_status of supplier is not right.
> 
> device_is_bound may be more elegant here. but it is not allowed to
> EXPORT from https://lore.kernel.org/patchwork/patch/1334670/.
> 
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> Tested-by: Frank Wunderlich <frank-w@...lic-files.de> # BPI-R2/MT7623

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>