linux-kernel - Re: [PATCH v9 02/15] iommu/mediatek-v1: Free the existed fwspec if the master dev already has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db984e48-a0fc-0802-0ce6-69d542c08771@collabora.com>
Date:   Tue, 11 Jan 2022 11:57:51 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Yong Wu <yong.wu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Joerg Roedel <joro@...tes.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        David Airlie <airlied@...ux.ie>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Will Deacon <will.deacon@....com>,
        dri-devel@...ts.freedesktop.org, yf.wang@...iatek.com,
        anthony.huang@...iatek.com, youlin.pei@...iatek.com,
        Evan Green <evgreen@...omium.org>,
        Eizan Miyamoto <eizan@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        linux-arm-kernel@...ts.infradead.org, mingyuan.ma@...iatek.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>, libo.kang@...iatek.com,
        yi.kuo@...iatek.com, linux-mediatek@...ts.infradead.org,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Tiffany Lin <tiffany.lin@...iatek.com>, anan.sun@...iatek.com,
        srv_heupstream@...iatek.com, acourbot@...omium.org,
        linux-kernel@...r.kernel.org, Tomasz Figa <tfiga@...omium.org>,
        iommu@...ts.linux-foundation.org, Daniel Vetter <daniel@...ll.ch>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v9 02/15] iommu/mediatek-v1: Free the existed fwspec if
 the master dev already has

Il 12/11/21 11:54, Yong Wu ha scritto:
> When the iommu master device enters of_iommu_xlate, the ops may be
> NULL(iommu dev is defered), then it will initialize the fwspec here:
> 
> [<c0c9c5bc>] (dev_iommu_fwspec_set) from [<c06bda80>]
> (iommu_fwspec_init+0xbc/0xd4)
> [<c06bd9c4>] (iommu_fwspec_init) from [<c06c0db4>]
> (of_iommu_xlate+0x7c/0x12c)
> [<c06c0d38>] (of_iommu_xlate) from [<c06c10e8>]
> (of_iommu_configure+0x144/0x1e8)
> 
> BUT the mtk_iommu_v1.c only supports arm32, the probing flow still is a bit
> weird. We always expect create the fwspec internally. otherwise it will
> enter here and return fail.
> 
> static int mtk_iommu_create_mapping(struct device *dev,
> 				    struct of_phandle_args *args)
> {
>          ...
> 	if (!fwspec) {
> 	        ....
> 	} else if (dev_iommu_fwspec_get(dev)->ops != &mtk_iommu_ops) {
>                  >>>>>>>>>>Enter here. return fail.<<<<<<<<<<<<
> 		return -EINVAL;
> 	}
> 	...
> }
> 
> Thus, Free the existed fwspec if the master device already has fwspec.
> 
> This issue is reported at:
> https://lore.kernel.org/linux-mediatek/trinity-7d9ebdc9-4849-4d93-bfb5-429dcb4ee449-1626253158870@3c-app-gmx-bs01/
> 
> Reported-by: Frank Wunderlich <frank-w@...lic-files.de>
> Tested-by: Frank Wunderlich <frank-w@...lic-files.de> # BPI-R2/MT7623
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>

Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>