linux-kernel - Re: [PATCH 1/1] ucsi_ccg: Check DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jan 2022 13:29:50 +0000
From:   Wayne Chang <waynec@...dia.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Sing-Han Chen <singhanc@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] ucsi_ccg: Check DEV_INT bit only when starting CCG4

Hi Heikki,

Thanks for the review.

On 1/10/22 7:40 PM, Heikki Krogerus wrote:
> 
> 
> Hi,
> 
> On Fri, Jan 07, 2022 at 05:24:55PM +0800, Wayne Chang wrote:
>> From: Sing-Han Chen <singhanc@...dia.com>
>>
>> after driver sending the UCSI_START cmd, CCGx would
>> clear Bit 0:Device Interrupt in the INTR_REG if CCGX
>> reset successfully.
>>
>> however, there might be a chance that other bits in
>> INTR_REG are not cleared due to internal data queued
>> in PPM and cause the driver thinks CCGx reset failed.
>>
>> the commit checks bit 0 in INTR_REG and ignore other
>> bits. ucsi driver would reset PPM later.
>>
>> Signed-off-by: Sing-Han Chen <singhanc@...dia.com>
>> Signed-off-by: WayneChang <waynec@...dia.com>
>                   ^^^^^^^^^^
> You probable should have a space there. In any case, FWIW:
> 
> Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 

Yes, I'll update the commit message and send it out.

>> ---
>>   drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
>> index bff96d64dddf..6db7c8ddd51c 100644
>> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
>> +++ b/rivers/usb/typec/ucsi/ucsi_ccg.c
>> @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc)
>>                if (status < 0)
>>                        return status;
>>
>> -             if (!data)
>> +             if (!(data & DEV_INT))
>>                        return 0;
>>
>>                status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data));
>> --
>> 2.25.1
> 
> thanks,
> 
> --
> heikki
> 

thanks,
Wayne.