linux-kernel - Re: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jan 2022 10:23:46 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ming Wang <wangming01@...ngson.cn>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end
 of the statement.

On Sat, Jan 08, 2022 at 05:09:37PM +0800, Ming Wang wrote:
> Even so, there is no syntax error. But, this may be a
> clerical error. ';' are more appropriate than ','.
> 
> Signed-off-by: Ming Wang <wangming01@...ngson.cn>

Applied to pci/misc for v5.17, thanks!

> ---
>  drivers/misc/pci_endpoint_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 2ed7e3a..8f786a2 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
>  		goto err_release_irq;
>  	}
>  	misc_device->parent = &pdev->dev;
> -	misc_device->fops = &pci_endpoint_test_fops,
> +	misc_device->fops = &pci_endpoint_test_fops;
>  
>  	err = misc_register(misc_device);
>  	if (err) {
> -- 
> 1.8.3.1
>