linux-kernel - [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jan 2022 10:38:00 -0600
From:   Tyler Hicks <tyhicks@...ux.microsoft.com>
To:     Lei Wang <lewan@...rosoft.com>, Borislav Petkov <bp@...en8.de>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Sinan Kaya <okaya@...nel.org>,
        Shiping Ji <shiping.linux@...il.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line

The dmc520 driver requires that at least one interrupt line, out of the ten
possible, is configured. The driver prints an error and returns -EINVAL
from its .probe function if there are no interrupt lines configured.

Don't print a KERN_ERR level message for each interrupt line that's
unconfigured as that can confuse users into thinking that there is an
error condition.

Before this change, the following KERN_ERR level messages would be
reported if only dram_ecc_errc and dram_ecc_errd were configured in the
device tree:

 dmc520 68000000.dmc: IRQ ram_ecc_errc not found
 dmc520 68000000.dmc: IRQ ram_ecc_errd not found
 dmc520 68000000.dmc: IRQ failed_access not found
 dmc520 68000000.dmc: IRQ failed_prog not found
 dmc520 68000000.dmc: IRQ link_err not
 dmc520 68000000.dmc: IRQ temperature_event not found
 dmc520 68000000.dmc: IRQ arch_fsm not found
 dmc520 68000000.dmc: IRQ phy_request not found

Fixes: 1088750d7839 ("EDAC: Add EDAC driver for DMC520")
Signed-off-by: Tyler Hicks <tyhicks@...ux.microsoft.com>
Cc: <stable@...r.kernel.org>
Reported-by: Sinan Kaya <okaya@...nel.org>
---
 drivers/edac/dmc520_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
index b8a7d9594afd..1fa5ca57e9ec 100644
--- a/drivers/edac/dmc520_edac.c
+++ b/drivers/edac/dmc520_edac.c
@@ -489,7 +489,7 @@ static int dmc520_edac_probe(struct platform_device *pdev)
 	dev = &pdev->dev;
 
 	for (idx = 0; idx < NUMBER_OF_IRQS; idx++) {
-		irq = platform_get_irq_byname(pdev, dmc520_irq_configs[idx].name);
+		irq = platform_get_irq_byname_optional(pdev, dmc520_irq_configs[idx].name);
 		irqs[idx] = irq;
 		masks[idx] = dmc520_irq_configs[idx].mask;
 		if (irq >= 0) {
-- 
2.25.1