linux-kernel - Re: [PATCH 1/2] cgroup: rstat: use same convention to assign cgroup_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yd8yQFx/cOBGd6+N@slm.duckdns.org>
Date:   Wed, 12 Jan 2022 09:55:44 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Wei Yang <richard.weiyang@...il.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cgroup: rstat: use same convention to assign
 cgroup_base_stat

On Sat, Jan 08, 2022 at 12:38:16AM +0000, Wei Yang wrote:
> In function cgroup_base_stat_flush(), we update cgroup_base_stat by
> getting rstatc->bstat and adjust delta to related fields.
> 
> There are two convention to assign cgroup_base_stat in this function:
> 
>   * rstat2 = rstat1
>   * rstat2.cputime = rstat1.cputime
> 
> The second convention may make audience think just field "cputime" is
> updated, while cputime is the only field in cgroup_base_stat.
> 
> Let's use the same convention to eliminate this confusion.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>

Applied 1-2 to cgroup/for-5.18.

Thanks.

-- 
tejun