linux-kernel - Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yd9DDJ2HmptwIITA@smile.fi.intel.com>
Date:   Wed, 12 Jan 2022 23:07:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     linux-kernel@...r.kernel.org, giometti@...eenne.com,
        gregkh@...uxfoundation.org, rasm@...up.pt,
        jamesnuss@...ometrics.ca, akpm@...ux-foundation.org
Subject: Re: [PATCH] pps: clients: gpio: Propagate return value from
 pps_gpio_probe

On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
> If the pps-gpio driver was probed prior to the GPIO device it uses, the
> devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
> replaced that error code with -EINVAL, causing the pps-gpio probe to
> fail and not be retried later. Propagate the error return value so that
> deferred probe works properly.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Fixes: 161520451dfa (pps: new client driver using GPIO)
> Signed-off-by: Robert Hancock <robert.hancock@...ian.com>
> ---
>  drivers/pps/clients/pps-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index 35799e6401c9..2f4b11b4dfcd 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>  	/* GPIO setup */
>  	ret = pps_gpio_setup(dev);
>  	if (ret)
> -		return -EINVAL;
> +		return ret;
>  
>  	/* IRQ setup */
>  	ret = gpiod_to_irq(data->gpio_pin);
> -- 
> 2.31.1
> 

-- 
With Best Regards,
Andy Shevchenko