linux-kernel - Re: [PATCH net-next] Revert "of: net: support NVMEM cells with MAC in text format"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220111182809.23de1b21@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 11 Jan 2022 18:28:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Walle <michael@...le.cc>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] Revert "of: net: support NVMEM cells with MAC
 in text format"

On Tue, 11 Jan 2022 09:12:06 +0100 Michael Walle wrote:
> This reverts commit 9ed319e411915e882bb4ed99be3ae78667a70022.
> 
> We can already post process a nvmem cell value in a particular driver.
> Instead of having yet another place to convert the values, the post
> processing hook of the nvmem provider should be used in this case.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
> As mentioned in [1] I think we should discuss this a bit more and revert
> the patch for now before there are any users of it.
> 
> [1] https://lore.kernel.org/netdev/20211229124047.1286965-1-michael@walle.cc/

Revert seems reasonable since there are two different proposals, 
but I won't pretend to understand the space so if anyone has opinions
please share them.

> btw, now with net-next closed, should this patch have net-next or net as
> the queue in the subject?

net, technically, although currently the trees are pretty much
identical.