linux-kernel - Re: [PATCH] firmware: remove old CONFIG_FW_LOADER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yd49mAHPQ2crt4Wl@bombadil.infradead.org>
Date:   Tue, 11 Jan 2022 18:31:52 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: remove old CONFIG_FW_LOADER_MODULE test

On Tue, Jan 11, 2022 at 08:22:52PM +0100, Borislav Petkov wrote:
> On Tue, Jan 11, 2022 at 11:00:19AM -0800, Luis Chamberlain wrote:
> > Yeah I think this comes from the fact that modules get a respective
> > _MODULE define in the generated file
> > include/generated/autoconf.h 
> > 
> > For example:
> > 
> > vagrant@...vops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> > grep CONFIG_CRC8 .config
> > CONFIG_CRC8=m
> > vagrant@...vops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> > grep CONFIG_CRC8 include/generated/autoconf.h
> > #define CONFIG_CRC8_MODULE 1 
> > 
> > So I think the above was put in place to ask if its built-in or a
> > module.
> 
> Talk about magic:
> 
> $ grep FW_LOADER .config
> CONFIG_FW_LOADER=m
> $ grep FW_LOADER include/generated/autoconf.h 
> #define CONFIG_FW_LOADER_MODULE 1
> 
> It is probably even documented somewhere that the build generates
> CONFIG_%s_MODULE defines for testing in code...

Yeah, this is an opaque way to express this, I'll send a patch
replacement which I think which make this clearer.

  Luis