linux-kernel - Re: [PATCH 3/4] mm/memcg: retrieve parent memcg from css.parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jan 2022 00:24:21 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Roman Gushchin <guro@...com>
Cc:     Wei Yang <richard.weiyang@...il.com>, hannes@...xchg.org,
        mhocko@...nel.org, vdavydov.dev@...il.com,
        akpm@...ux-foundation.org, shakeelb@...gle.com, vbabka@...e.cz,
        willy@...radead.org, songmuchun@...edance.com, shy828301@...il.com,
        surenb@...gle.com, linux-kernel@...r.kernel.org,
        cgroups@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 3/4] mm/memcg: retrieve parent memcg from css.parent

On Tue, Jan 11, 2022 at 10:09:52AM -0800, Roman Gushchin wrote:
>On Tue, Jan 11, 2022 at 01:03:01AM +0000, Wei Yang wrote:
>> The parent we get from page_counter is correct, while this is two
>> different hierarchy.
>> 
>> Let's retrieve the parent memcg from css.parent just like parent_cs(),
>> blkcg_parent(), etc.
>
>Does it bring any benefits except consistency?
>

I am afraid no.

>> 
>> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
>
>Reviewed-by: Roman Gushchin <guro@...com>
>
>Thanks!

-- 
Wei Yang
Help you, Help me