linux-kernel - RE: [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jan 2022 14:28:08 +0900
From:   "Chanho Park" <chanho61.park@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...onical.com>,
        "'Tomasz Figa'" <tomasz.figa@...il.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        "'Linus Walleij'" <linus.walleij@...aro.org>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc:     "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        "'Sam Protsenko'" <semen.protsenko@...aro.org>,
        "'Alim Akhtar'" <alim.akhtar@...il.com>, <stable@...r.kernel.org>
Subject: RE: [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on
 error paths

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Sent: Wednesday, January 12, 2022 5:14 AM
> To: Tomasz Figa <tomasz.figa@...il.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@...onical.com>; Sylwester Nawrocki
> <s.nawrocki@...sung.com>; Linus Walleij <linus.walleij@...aro.org>; Rob
> Herring <robh+dt@...nel.org>; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; linux-gpio@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>; Sam Protsenko
> <semen.protsenko@...aro.org>; Chanho Park <chanho61.park@...sung.com>;
> Alim Akhtar <alim.akhtar@...il.com>; stable@...r.kernel.org
> Subject: [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on
> error paths
> 
> The driver iterates over its devicetree children with
> for_each_child_of_node() and stores for later found node pointer.  This
> has to be put in error paths to avoid leak during re-probing.
> 
> Fixes: ab663789d697 ("pinctrl: samsung: Match pin banks with their device
> nodes")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Reviewed-by: Chanho Park <chanho61.park@...sung.com>

Best Regards,
Chanho Park