linux-kernel - Re: [PATCH v3 22/23] media: atmel: atmel-isc: compact the controller formats list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220112090615.6mbzd7fwn4a7yjtw@uno.localdomain>
Date:   Wed, 12 Jan 2022 10:06:15 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Eugen Hristev <eugen.hristev@...rochip.com>
Cc:     linux-media@...r.kernel.org, robh+dt@...nel.org,
        laurent.pinchart@...asonboard.com, sakari.ailus@....fi,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...rochip.com
Subject: Re: [PATCH v3 22/23] media: atmel: atmel-isc: compact the controller
 formats list

Hi Eugen

On Mon, Dec 13, 2021 at 03:49:39PM +0200, Eugen Hristev wrote:
> Compact the list array to be more readable.
> No other changes, only cosmetic.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Reviewed-by: Jacopo Mondi <jacopo+renesas@...ndi.org>

Thanks
  j

> ---
>  .../media/platform/atmel/atmel-sama5d2-isc.c  | 51 ++++++----------
>  .../media/platform/atmel/atmel-sama7g5-isc.c  | 60 +++++++------------
>  2 files changed, 37 insertions(+), 74 deletions(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> index 025c3e8a7e95..d96ee3373889 100644
> --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> @@ -60,56 +60,39 @@
>  static const struct isc_format sama5d2_controller_formats[] = {
>  	{
>  		.fourcc		= V4L2_PIX_FMT_ARGB444,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_ARGB555,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_RGB565,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_ABGR32,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_XBGR32,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUV420,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUYV,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUV422P,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_GREY,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_Y10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SBGGR8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGBRG8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGRBG8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SRGGB8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SBGGR10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGBRG10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGRBG10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SRGGB10,
>  	},
>  };
> diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> index 9dc75eed0098..e07ae188c15f 100644
> --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> @@ -63,65 +63,45 @@
>  static const struct isc_format sama7g5_controller_formats[] = {
>  	{
>  		.fourcc		= V4L2_PIX_FMT_ARGB444,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_ARGB555,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_RGB565,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_ABGR32,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_XBGR32,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUV420,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_UYVY,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_VYUY,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUYV,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_YUV422P,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_GREY,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_Y10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_Y16,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SBGGR8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGBRG8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGRBG8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SRGGB8,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SBGGR10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGBRG10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SGRBG10,
> -	},
> -	{
> +	}, {
>  		.fourcc		= V4L2_PIX_FMT_SRGGB10,
>  	},
>  };
> --
> 2.25.1
>