linux-kernel - Re: [PATCH v4 1/1] ucsi_ccg: Check DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yd6ariWZtZN9PlBe@kuha.fi.intel.com>
Date:   Wed, 12 Jan 2022 11:09:02 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Wayne Chang <waynec@...dia.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Sing-Han Chen <singhanc@...dia.com>
Subject: Re: [PATCH v4 1/1] ucsi_ccg: Check DEV_INT bit only when starting
 CCG4

On Wed, Jan 12, 2022 at 08:41:50AM +0000, Wayne Chang wrote:
> Hi Heikki
> 
> Thanks for the review.
> 
> On 1/12/22 3:50 PM, Heikki Krogerus wrote:
> > 
> > 
> > Hi,
> > 
> > On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote:
> >> From: Sing-Han Chen <singhanc@...dia.com>
> >>
> >> after driver sending the UCSI_START cmd, CCGx would
> >> clear Bit 0:Device Interrupt in the INTR_REG if CCGX
> >> reset successfully.
> >>
> >> however, there might be a chance that other bits in
> >> INTR_REG are not cleared due to internal data queued
> >> in PPM and cause the driver thinks CCGx reset failed.
> >>
> >> the commit checks bit 0 in INTR_REG and ignore other
> >> bits. ucsi driver would reset PPM later.
> >>
> >> Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx")
> > 
> > So... no need to take this to the stable kernel releases?
> > 
> Should I put cc tag here?

Yes, Cc: stable@...nel.org, unless you have some good reason not to.
I'm guessing you don't. This stuff is also explained here:

https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch

> >> Signed-off-by: Sing-Han Chen <singhanc@...dia.com>
> >> Signed-off-by: Wayne Chang <waynec@...dia.com>
> >> ---
> > 
> > What has changed since v3 (and v2) - there is no patch changelog here?
> > 
> > In case this is new to you, you list those changes under that '---'
> > line so they don't become part of the permanent changelog:
> > 
> > https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
> > 
> The changes are resent for updating the commit messages.
> Added the Fixes tag which Greg asked for.
> Thanks for information. I went through the documents.
> Should I put the following messages in the patch after "---" or should I use resend in subject 
> for the commit messages updated?
> v3 -> v4 commit messages updated

I think you can say exactly what you did, like "Added the Fixes tag"
or whatever you did.

> v2 -> v3 commit messages updated

Ditto.

> v1 -> v2 commit messages updated

Ditto.

Since you are going to do one more version of this, could you also
start the sentences with upper-case letters in the commit message?
Normally I'm not very picky about the grammar stuff (I make plenty of
mistakes myself), but this time it's driving me crazy for some reason.

thanks,

-- 
heikki