linux-kernel - Re: [PATCH v1 1/1] gpio: tegra: Get rid of duplicate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yd7TkUKo2g2Asbna@orome>
Date:   Wed, 12 Jan 2022 14:11:45 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Thierry Reding <treding@...dia.com>,
        linux-gpio@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>,
        Jonathan Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v1 1/1] gpio: tegra: Get rid of duplicate of_node
 assignment

On Thu, Dec 23, 2021 at 02:26:39PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
> 
> For the details one may look into the of_gpio_dev_init() implementation.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-tegra.c | 1 -
>  1 file changed, 1 deletion(-)

Yep, this is indeed not necessary (anymore), so:

Reviewed-by: Thierry Reding <treding@...dia.com>

I've also given this a quick spin on a Tegra124 device (Venice 2) and
everything seems to be working fine, so also:

Tested-by: Thierry Reding <treding@...dia.com>

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)