linux-kernel - Re: [PATCH] phy: freescale: i.MX8 PHYs should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yd7jqwG/qmkSXfPz@qwark.sigxcpu.org>
Date:   Wed, 12 Jan 2022 15:20:27 +0100
From:   Guido Günther <agx@...xcpu.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Richard Zhu <hongxing.zhu@....com>, Li Jun <jun.li@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: freescale: i.MX8 PHYs should depend on ARCH_MXC &&
 ARM64

Hi,
On Wed, Jan 12, 2022 at 12:40:38PM +0100, Geert Uytterhoeven wrote:
> The Freescale/NXP i.MX8 USB3, MIPI DSI, and PCIE PHYs are only present
> on the NXP i.MX8 family of SoCs.  Hence wrap the config symbols for
> these PHYs inside a check for ARCH_MXC && ARM64, to prevent asking the
> user about these drivers when configuring a kernel without NXP i.MX SoC
> family support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Sounds good to me:

Reviewed-by: Guido Günther <agx@...xcpu.org>

Cheers,
 -- Guido

> ---
>  drivers/phy/freescale/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig
> index c3669c28ea9fe83a..856cbec7057d9e54 100644
> --- a/drivers/phy/freescale/Kconfig
> +++ b/drivers/phy/freescale/Kconfig
> @@ -1,4 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> +
> +if (ARCH_MXC && ARM64) || COMPILE_TEST
> +
>  config PHY_FSL_IMX8MQ_USB
>  	tristate "Freescale i.MX8M USB3 PHY"
>  	depends on OF && HAS_IOMEM
> @@ -22,3 +25,5 @@ config PHY_FSL_IMX8M_PCIE
>  	help
>  	  Enable this to add support for the PCIE PHY as found on
>  	  i.MX8M family of SOCs.
> +
> +endif
> -- 
> 2.25.1
>