linux-kernel - Re: [PATCH] drivers/hwmon: remove redundant freq variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220112154444.GA386615@roeck-us.net>
Date:   Wed, 12 Jan 2022 07:44:44 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     cgel.zte@...il.com
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/hwmon: remove redundant freq variable

On Wed, Jan 12, 2022 at 08:26:02AM +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value directly instead of taking this in another redundant
> variable.
> 

Again, please stop sending me such patches. And, again, the variable
is not "redundant" even though there is a partial match in meaning.
A better term would be "unnecessary". However, as mentioned before,
that is POV because we don't know if the original submitter kept
the variable to simplify adding debug code.

Guenter

> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  drivers/hwmon/w83627hf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
> index 9be277156ed2..0feb581975cf 100644
> --- a/drivers/hwmon/w83627hf.c
> +++ b/drivers/hwmon/w83627hf.c
> @@ -283,9 +283,7 @@ static int TEMP_FROM_REG(u8 reg)
>  
>  static inline unsigned long pwm_freq_from_reg_627hf(u8 reg)
>  {
> -	unsigned long freq;
> -	freq = W83627HF_BASE_PWM_FREQ >> reg;
> -	return freq;
> +	return W83627HF_BASE_PWM_FREQ >> reg;
>  }
>  static inline u8 pwm_freq_to_reg_627hf(unsigned long val)
>  {
> -- 
> 2.25.1
>