linux-kernel - Re: [PATCH v2] KVM: x86: Make the module parameter of vPMU more common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yd7/yUFQr3pbqVCi@google.com>
Date:   Wed, 12 Jan 2022 16:20:25 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Like Xu <like.xu.linux@...il.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Jim Mattson <jmattson@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Joerg Roedel <joro@...tes.org>, x86@...nel.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Make the module parameter of vPMU more
 common

On Wed, Jan 12, 2022, Like Xu wrote:
> ---
> v1 -> v2 Changelog:
> - prefer we keep "pmu" for the module param; (Sean)

...
> +/* Enable/disable PMU virtualization */
> +bool __read_mostly pmu = true;
> +EXPORT_SYMBOL_GPL(pmu);
> +module_param(pmu, bool, 0444);

Sorry, I should have been more explicit.  What I meant was this:

  /* Enable/disable PMU virtualization */
  bool __read_mostly enable_pmu = true;
  module_param_named(pmu, enable_pmu, bool, 0444);

That way KVM can use "enable_pmu" for all its checks, but the user only needs to
type "pmu=?" when manipulating the module param.