linux-kernel - Re: [PATCH] drivers/acpi/apei: remove redundant rc variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iipOm6DX3Fd8iNKF_LC6kJWCy=1LxFsh47z01UYDrRow@mail.gmail.com>
Date:   Wed, 12 Jan 2022 17:34:02 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     cgel.zte@...il.com
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/acpi/apei: remove redundant rc variable

On Wed, Jan 12, 2022 at 9:02 AM <cgel.zte@...il.com> wrote:
>
> From: Minghao Chi <chi.minghao@....com.cn>
>
> Return value from apei_exec_write_register() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>

Well, this doesn't look like an e-mail address of a physical person
which is required for S-o-b tags.

> ---
>  drivers/acpi/apei/apei-base.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
> index c7fdb12c3310..87145b6b89aa 100644
> --- a/drivers/acpi/apei/apei-base.c
> +++ b/drivers/acpi/apei/apei-base.c
> @@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
>  int apei_exec_write_register_value(struct apei_exec_context *ctx,
>                                    struct acpi_whea_header *entry)
>  {
> -       int rc;
> -
>         ctx->value = entry->value;
> -       rc = apei_exec_write_register(ctx, entry);
> +       return apei_exec_write_register(ctx, entry);
>
> -       return rc;
>  }
>  EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
>
> --
> 2.25.1
>