| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yd8fJd2SASGkhOjm@pendragon.ideasonboard.com>
Date: Wed, 12 Jan 2022 20:34:13 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>
Cc: linux-media@...r.kernel.org, kernel-list@...pberrypi.com,
mchehab@...nel.org, dave.stevenson@...pberrypi.com,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
naush@...pberrypi.com, lukasz@...y.st, devicetree@...r.kernel.org
Subject: Re: [RFC PATCH 1/3] media: dt-bindings: media: Add bindings for
bcm2835-unicam
Hi Jean-Michel,
Thank you for the patch.
On Wed, Jan 12, 2022 at 06:27:18PM +0100, Jean-Michel Hautbois wrote:
> Introduce the dt-bindinds documentation for bcm2835 CCP2/CSI2 camera
> interface. Also add a MAINTAINERS entry for it.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> Signed-off-by: Naushir Patuck <naush@...pberrypi.com>
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>
> ---
> Dave: I assumed you were the maintainer for this file, as I based it on the
> bcm2835-unicam.txt file. Are you happy to be added directly as the
> maintainer, or should this be specified as "Raspberry Pi Kernel
> Maintenance <kernel-list@...pberrypi.com>"
> ---
> .../bindings/media/brcm,bcm2835-unicam.yaml | 103 ++++++++++++++++++
> MAINTAINERS | 6 +
> 2 files changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
> new file mode 100644
> index 000000000000..1427514142cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/brcm,bcm2835-unicam.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM283x Camera Interface (Unicam)
> +
> +maintainers:
> + - Dave Stevenson <dave.stevenson@...pberrypi.com>
> +
> +description: |-
> + The Unicam block on BCM283x SoCs is the receiver for either
> + CSI-2 or CCP2 data from image sensors or similar devices.
> +
> + The main platform using this SoC is the Raspberry Pi family of boards.
> + On the Pi the VideoCore firmware can also control this hardware block,
> + and driving it from two different processors will cause issues.
> + To avoid this, the firmware checks the device tree configuration
> + during boot. If it finds device tree nodes called csi0 or csi1 then
> + it will stop the firmware accessing the block, and it can then
> + safely be used via the device tree binding.
> +
> +properties:
> + compatible:
> + const: brcm,bcm2835-unicam
> +
> + reg:
> + description:
> + physical base address and length of the register sets for the device.
You can drop the description, that's the default for the reg property.
> + maxItems: 1
> +
> + interrupts:
> + description: the IRQ line for this Unicam instance.
Same here.
> + maxItems: 1
> +
> + clocks:
> + description: |-
> + list of clock specifiers, corresponding to entries in clock-names
> + property.
Same here, but a description of each entry would be useful.
clocks:
items:
- description: Clock for foo.
- description: Clock for bar.
> +
> + clock-names:
> + items:
> + - const: lp
> + - const: vpu
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
You need to use port-base and list the valid endpoint properties.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - port
> +
> +additionalProperties: False
s/False/false/
> +
> +examples:
> + - |
Does this validate without #include'ing headers that define the
BCM2835_CLOCK_CAM1 macro ?
> + csi1: csi1@...01000 {
You can drop the label.
> + compatible = "brcm,bcm2835-unicam";
> + reg = <0x7e801000 0x800>,
> + <0x7e802004 0x4>;
That's two items, while the bindings document one item only. Please run
the DT bindings validation, it will validate the examples.
> + interrupts = <2 7>;
On RPi 4 don't we need 3 interrupt cells ?
> + clocks = <&clocks BCM2835_CLOCK_CAM1>,
> + <&firmware_clocks 4>;
> + clock-names = "lp", "vpu";
A blank line would be good here.
> + port {
> + csi1_ep: endpoint {
Inconsistent indentation. Same below.
> + remote-endpoint = <&tc358743_0>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> +
> + i2c0: i2c@...05000 {
> + tc358743: csi-hdmi-bridge@0f {
You can drop those two labels.
> + compatible = "toshiba,tc358743";
This isn't documented upstream in yaml. How about using an imx219 sensor
instead ?
> + reg = <0x0f>;
> + clocks = <&tc358743_clk>;
> + clock-names = "refclk";
> +
> + tc358743_clk: bridge-clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <27000000>;
> + };
You can drop this, there's no need to declare the clock in the example.
> +
> + port {
> + tc358743_0: endpoint {
> + remote-endpoint = <&csi1_ep>;
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + clock-noncontinuous;
> + link-frequencies =
> + /bits/ 64 <297000000>;
> + };
> + };
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 269aa4d6b94a..7484255cad31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3653,6 +3653,12 @@ N: bcm113*
> N: bcm216*
> N: kona
>
> +BROADCOM BCM2835 CAMERA DRIVER
> +M: Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>
> +L: linux-media@...r.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
> +
> BROADCOM BCM47XX MIPS ARCHITECTURE
> M: Hauke Mehrtens <hauke@...ke-m.de>
> M: Rafał Miłecki <zajec5@...il.com>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists