linux-kernel - Re: [PATCH crypto 2/2] lib/crypto: blake2s: move hmac construction into wireguard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yd8fevK3n5aACJMF@gmail.com>
Date:   Wed, 12 Jan 2022 10:35:38 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
        wireguard@...ts.zx2c4.com, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, geert@...ux-m68k.org, tytso@....edu,
        gregkh@...uxfoundation.org, jeanphilippe.aumasson@...il.com,
        ardb@...nel.org, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH crypto 2/2] lib/crypto: blake2s: move hmac construction
 into wireguard

On Tue, Jan 11, 2022 at 02:49:34PM +0100, Jason A. Donenfeld wrote:
> Basically nobody should use blake2s in an HMAC construction; it already
> has a keyed variant. But for unfortunately historical reasons, Noise,
> used by WireGuard, uses HKDF quite strictly, which means we have to use
> this. Because this really shouldn't be used by others, this commit moves
> it into wireguard's noise.c locally, so that kernels that aren't using
> WireGuard don't get this superfluous code baked in. On m68k systems,
> this shaves off ~314 bytes.
> 
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: wireguard@...ts.zx2c4.com
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric