linux-kernel - Re: [PATCH -next v2] scsi: efct: don't use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jan 2022 11:28:48 -0800
From:   James Smart <jsmart2021@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, target-devel@...r.kernel.org,
        linux-scsi@...r.kernel.org
Cc:     hch@....de, james.smart@...adcom.com, martin.petersen@...cle.com
Subject: Re: [PATCH -next v2] scsi: efct: don't use GFP_KERNEL under spin lock

On 1/10/2022 5:24 PM, Yang Yingliang wrote:
> GFP_KERNEL/GFP_DMA can't be used under a spin lock, according the
> comment of els_ios_lock, it's used to protect els ios list, so we
> can move down the spin lock to avoid using this flag under the lock.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 8f406ef72859 ("scsi: elx: libefc: Extended link Service I/O handling")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> v2:
>    move up unlock to just protect list_add_tail()
> ---
>   drivers/scsi/elx/libefc/efc_els.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 

Looks fine.

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james