linux-kernel - Re: Re: [PATCH] media: vidtv: Check for null return of vzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220112020720.692110-1-jiasheng@iscas.ac.cn>
Date:   Wed, 12 Jan 2022 10:07:20 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     hverkuil@...all.nl, dwlsalmeida@...il.com, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH] media: vidtv: Check for null return of vzalloc

On Tue, Jan 11, 2022 at 05:58:10PM +0800, Hans Verkuil wrote:
> This doesn't free e->name!
> 
> Actually, the same issue is also present later in this function:
>
> ctx = kzalloc(priv_sz, GFP_KERNEL);
>        if (!ctx) {
>	        kfree(e);
>	        return NULL;
>	}

>> +		kfree(e);
>> +		return NULL;
>> +	}

Thanks for your reminder.
I have sent a v2 to fix it.
And also I have sent a patch to fix the 'ctx' with
'Reported-by: Hans Verkuil <hverkuil@...all.nl>',
since they are two different things.

Sincerely thanks,
Jiang