linux-kernel - Re: [PATCH v2 1/3] drm/bridge: anx7625: Convert to use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e676870-11f2-b5fa-faf1-d6633e801a5a@wanadoo.fr>
Date:   Thu, 13 Jan 2022 09:04:39 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Hsin-Yi Wang <hsinyi@...omium.org>,
        Robert Foss <robert.foss@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, Xin Ji <xji@...logixsemi.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH v2 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc

Le 13/01/2022 à 08:31, Hsin-Yi Wang a écrit :
> Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
> handled by driver detach.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> Reviewed-by: Xin Ji <xji@...logixsemi.com>
> ---
>   drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0b858c78abe8b6..dbe708eb3bcf11 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2515,7 +2515,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   		return -ENODEV;
>   	}
>   
> -	platform = kzalloc(sizeof(*platform), GFP_KERNEL);
> +	platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
>   	if (!platform) {
>   		DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
>   		return -ENOMEM;
> @@ -2527,7 +2527,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   	if (ret) {
>   		if (ret != -EPROBE_DEFER)
>   			DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
> -		goto free_platform;
> +		return ret;
>   	}
>   
>   	platform->client = client;
> @@ -2552,7 +2552,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   	if (!platform->hdcp_workqueue) {
>   		dev_err(dev, "fail to create work queue\n");
>   		ret = -ENOMEM;
> -		goto free_platform;
> +		return ret;
>   	}
>   
>   	platform->pdata.intp_irq = client->irq;
> @@ -2637,9 +2637,6 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   	if (platform->hdcp_workqueue)
>   		destroy_workqueue(platform->hdcp_workqueue);
>   
> -free_platform:
> -	kfree(platform);
> -
>   	return ret;
>   }
>   

Hi,

you also need to update anx7625_i2c_remove() accordingly, otherwise you 
introduce a double free.

CJ