linux-kernel - Re: [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a2e7c29-aa0a-ced4-7107-beba8268eca1@amd.com>
Date:   Thu, 13 Jan 2022 15:58:20 +0530
From:   "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Elie Morisse <syniurge@...il.com>,
        Shyam Sundar S K <shyam-sundar.s-k@....com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback
 configuration

On 1/9/2022 6:04 PM, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lkml.org/lkml/2021/6/7/398
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/i2c/busses/i2c-amd-mp2-pci.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c
> index adf0e8c1ec01..f57077a7448d 100644
> --- a/drivers/i2c/busses/i2c-amd-mp2-pci.c
> +++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c
> @@ -308,11 +308,8 @@ static int amd_mp2_pci_init(struct amd_mp2_dev *privdata,
>   	pci_set_master(pci_dev);
>   
>   	rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(64));
> -	if (rc) {
> -		rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32));
> -		if (rc)
> -			goto err_dma_mask;
> -	}
> +	if (rc)
> +		goto err_dma_mask;
>   
>   	/* Set up intx irq */
>   	writel(0, privdata->mmio + AMD_P2C_MSG_INTEN);
> 
Acked-by: Nehal Bakulchandra Shah<Nehal-bakulchandra.Shah@....com>