linux-kernel - Re: [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <735d2b47-227f-f09d-ddd6-28bc82a066a5@redhat.com>
Date:   Thu, 13 Jan 2022 12:16:55 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Thomas Zimmermann <tzimmermann@...e.de>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Borislav Petkov <bp@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/firmware: Add missing platform_device_put() in
 sysfb_create_simplefb

Hello Miaoqian,

On 12/31/21 09:04, Miaoqian Lin wrote:
> Add the missing platform_device_put() before return from
> sysfb_create_simplefb() in the error handling case.
> 
> Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---

Thanks for the patch.

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

>  drivers/firmware/sysfb_simplefb.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
> index b86761904949..303a491e520d 100644
> --- a/drivers/firmware/sysfb_simplefb.c
> +++ b/drivers/firmware/sysfb_simplefb.c
> @@ -113,12 +113,16 @@ __init int sysfb_create_simplefb(const struct screen_info *si,
>  	sysfb_apply_efi_quirks(pd);
>  
>  	ret = platform_device_add_resources(pd, &res, 1);
> -	if (ret)
> +	if (ret) {
> +		platform_device_put(pd);
>  		return ret;
> +	}
>  
>  	ret = platform_device_add_data(pd, mode, sizeof(*mode));
> -	if (ret)
> +	if (ret) {
> +		platform_device_put(pd);
>  		return ret;
> +	}
>

To avoid duplicating the error code logic twice, you could also do:

	if (ret)
		goto pdev_put;
  
>  	return platform_device_add(pd);

and then after this return statement:

pdev_put:
	platform_device_put(pd);
	return ret;

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat