linux-kernel - Re: [PATCH v5 3/3] m68k: virt: Remove LEGACY_TIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2_cJi9+SNi9gK6+5kpBo4wmVw4hz42Bq_jm1+s6AvENQ@mail.gmail.com>
Date:   Thu, 13 Jan 2022 12:20:04 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Laurent Vivier <laurent@...ier.eu>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v5 3/3] m68k: virt: Remove LEGACY_TIMER_TICK

On Thu, Jan 13, 2022 at 11:35 AM Laurent Vivier <laurent@...ier.eu> wrote:
>
> Move virt machine to generic clockevents.
>
> cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Laurent Vivier <laurent@...ier.eu>

The change looks good, but it appears that you only just add the legacy code
in the same series, and it would be easier to just add the correct version
first.

> diff --git a/arch/m68k/virt/timer.c b/arch/m68k/virt/timer.c
> index 843bf6ed7e1a..767b01f75abb 100644
> --- a/arch/m68k/virt/timer.c
> +++ b/arch/m68k/virt/timer.c

How about moving the entire file to drivers/clocksource/timer-goldfish.c?
It shouldn't even be architecture specific any more at this point. It probably
still is in practice, but that could be addressed when another architecture
wants to share the implementation.

         Arnd