linux-kernel - drivers/platform/x86/asus-tf103c-dock.c:253:22: sparse: sparse: symbol 'tf103c_dock_hid_ll_driver' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202201131019.hPdr89Fv-lkp@intel.com>
Date:   Thu, 13 Jan 2022 10:29:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/platform/x86/asus-tf103c-dock.c:253:22: sparse: sparse:
 symbol 'tf103c_dock_hid_ll_driver' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   362f533a2a1098fe95020cb59340023e9b11d062
commit: 0a6509b0926dea5ebbd2c86551b7681b00585961 platform/x86: Add Asus TF103C dock driver
date:   8 days ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220113/202201131019.hPdr89Fv-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0a6509b0926dea5ebbd2c86551b7681b00585961
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 0a6509b0926dea5ebbd2c86551b7681b00585961
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/platform/x86/asus-tf103c-dock.c:253:22: sparse: sparse: symbol 'tf103c_dock_hid_ll_driver' was not declared. Should it be static?
>> drivers/platform/x86/asus-tf103c-dock.c:924:1: sparse: sparse: symbol 'tf103c_dock_pm_ops' was not declared. Should it be static?

vim +/tf103c_dock_hid_ll_driver +253 drivers/platform/x86/asus-tf103c-dock.c

   252	
 > 253	struct hid_ll_driver tf103c_dock_hid_ll_driver = {
   254		.parse = tf103c_dock_hid_parse,
   255		.start = tf103c_dock_hid_start,
   256		.stop = tf103c_dock_hid_stop,
   257		.open = tf103c_dock_hid_open,
   258		.close = tf103c_dock_hid_close,
   259		.raw_request = tf103c_dock_hid_raw_request,
   260	};
   261	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org