linux-kernel - Re: [PATCH v13 2/3] dt-bindings: mmc: Add bindings for LiteSDCard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YeBWeqCAWxVXXrLE@errol.ini.cmu.edu>
Date:   Thu, 13 Jan 2022 11:42:34 -0500
From:   "Gabriel L. Somlo" <gsomlo@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     david.abdurachmanov@...ive.com, geert@...ux-m68k.org,
        ulf.hansson@...aro.org, linux-kernel@...r.kernel.org,
        mdudek@...ernships.antmicro.com, shorne@...il.com,
        paulus@...abs.org, joel@....id.au, andy.shevchenko@...il.com,
        kgugala@...micro.com, florent@...oy-digital.fr, hdanton@...a.com,
        devicetree@...r.kernel.org, mholenko@...micro.com,
        linux-mmc@...r.kernel.org, krakoczy@...micro.com,
        robh+dt@...nel.org, rdunlap@...radead.org
Subject: Re: [PATCH v13 2/3] dt-bindings: mmc: Add bindings for LiteSDCard

On Thu, Jan 13, 2022 at 10:29:34AM -0600, Rob Herring wrote:
> On Wed, 12 Jan 2022 17:27:46 -0500, Gabriel Somlo wrote:
> > LiteSDCard is a small footprint, configurable SDCard core for
> > FPGA based SoCs.
> > 
> > Signed-off-by: Gabriel Somlo <gsomlo@...il.com>
> > Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > Reviewed-by: Joel Stanley <joel@....id.au>
> > ---
> > 
> > New in v13:
> >   - add `vmmc-supply` requirement
> > 
> >  .../devicetree/bindings/mmc/litex,mmc.yaml    | 77 +++++++++++++++++++
> >  1 file changed, 77 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mmc/litex,mmc.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.example.dt.yaml: mmc@...05000: 'vmmc-supply' is a required property

Oh, I forgot to add `vmmc-suply = ...` to the `examples` section --
sorry about that. Version 14 will be out shortly with a fix.

Thanks,
--Gabriel

> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1579360
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
>