linux-kernel - Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW5HLK=DoNWmROXrce+9AcNBDLhjuoXQy2T0A_DQ34PBfQ@mail.gmail.com>
Date:   Thu, 13 Jan 2022 09:07:32 -0800
From:   Song Liu <song@...nel.org>
To:     menglong8.dong@...il.com
Cc:     Shuah Khan <shuah@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, davemarchevsky@...com,
        linux-kselftest@...r.kernel.org,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, imagedong@...cent.com
Subject: Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

On Wed, Jan 12, 2022 at 7:17 PM <menglong8.dong@...il.com> wrote:
>
> From: Menglong Dong <imagedong@...cent.com>
>
> 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
> used, just remove them.
>
> Signed-off-by: Menglong Dong <imagedong@...cent.com>

Acked-by: Song Liu <songliubraving@...com>

> ---
>  tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> index 95d5b941bc1f..c9abfe3a11af 100644
> --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
>  {
>         void *data_end = (void *)(long) skb->data_end;
>         void *data = (void *)(long) skb->data;
> -       __u32 lport = skb->local_port;
> -       __u32 rport = skb->remote_port;
>         __u8 *d = data;
>         int err;
>
> --
> 2.34.1
>