linux-kernel - Re: [PATCH v1 05/14] arm64: defconfig: build imx-sdma as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06d3ff4c-3c82-1b04-3dc7-3a6effe4cc3e@i2se.com>
Date:   Thu, 13 Jan 2022 19:42:57 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Marcel Ziswiler <marcel@...wiler.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Marek Vasut <marek.vasut@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Arnd Bergmann <arnd@...db.de>,
        Biju Das <biju.das.jz@...renesas.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Guido Günther <agx@...xcpu.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Olof Johansson <olof@...om.net>,
        Shawn Guo <shawnguo@...nel.org>, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 05/14] arm64: defconfig: build imx-sdma as a module

Hi Marcel,

Am 07.01.22 um 19:03 schrieb Marcel Ziswiler:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
>
> This avoids firmware load error and sysfs fallback reported as follows:
>
> [    0.199448] imx-sdma 302c0000.dma-controller: Direct firmware load
>  for imx/sdma/sdma-imx7d.bin failed with error -2
> [    0.199487] imx-sdma 302c0000.dma-controller: Falling back to sysfs
>  fallback for: imx/sdma/sdma-imx7d.bin

unfortunately this isn't an explanation why this solve the issue. It
looks like that the SDMA firmware is not available for the kernel. Build
the driver as a module hide the issue and just load it if the rootfs is
available.

What makes you sure that the driver is not critical for other boards
during boot?

Best regards

>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> ---
>
>  arch/arm64/configs/defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 3c8106c5776a..a18785a827dc 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -915,7 +915,7 @@ CONFIG_DMADEVICES=y
>  CONFIG_DMA_BCM2835=y
>  CONFIG_DMA_SUN6I=m
>  CONFIG_FSL_EDMA=y
> -CONFIG_IMX_SDMA=y
> +CONFIG_IMX_SDMA=m
>  CONFIG_K3_DMA=y
>  CONFIG_MV_XOR=y
>  CONFIG_MV_XOR_V2=y