[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BYAPR11MB3367C34AB2311D81468B457DFC549@BYAPR11MB3367.namprd11.prod.outlook.com>
Date: Fri, 14 Jan 2022 04:08:02 +0000
From: "G, GurucharanX" <gurucharanx.g@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>,
"Jakub Kicinski" <kuba@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
Christoph Hellwig <hch@....de>,
"Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] i40e: Remove useless DMA-32 fallback configuration
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Sent: Sunday, January 9, 2022 11:00 PM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>;
> Jakub Kicinski <kuba@...nel.org>
> Cc: linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org;
> Christophe JAILLET <christophe.jaillet@...adoo.fr>; Christoph Hellwig
> <hch@....de>; Lobakin, Alexandr <alexandr.lobakin@...el.com>; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org
> Subject: [PATCH] i40e: Remove useless DMA-32 fallback configuration
>
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lkml.org/lkml/2021/6/7/398
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists