linux-kernel - Re: [PATCH v1 8/9] drivers: hv: dxgkrnl: Implement various WDDM ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeEMTGqDI1UApH81@kroah.com>
Date:   Fri, 14 Jan 2022 06:38:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Iouri Tarassov <iourit@...ux.microsoft.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, spronovo@...rosoft.com
Subject: Re: [PATCH v1 8/9] drivers: hv: dxgkrnl: Implement various WDDM
 ioctls

On Thu, Jan 13, 2022 at 04:19:41PM -0800, Iouri Tarassov wrote:
> 
> On 1/12/2022 11:47 PM, Greg KH wrote:
> > On Wed, Jan 12, 2022 at 11:55:13AM -0800, Iouri Tarassov wrote:
> > > Implement various WDDM IOCTLs.
> > > Again, break this up into smaller pieces.  Would you want to review
> > all
> > of these at the same time?
> > 
> > Remember, you write code for people to review and understand first, and
> > the compiler second.  With large changes like this, you are making it
> > difficult for people to review, which is your target audience.
> > 
> > I'll stop here, please fix up this patch series into something that is
> > reviewable.
> 
> Hi Greg,
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> states that "only post say 15 [patches] or so at a time and wait for review
> and integration".
> The IOCTLs here are simple and I tried to keep the number of patches smaller
> than 15. Is it ok to have more than 15 patches in a submission, or I need to
> submit the driver is several chunks (some of which would be not fully
> functional)?

We get patch series that are much longer all the time, that's fine.  How
many do you feel would be needed to properly break this out?

Again, create changes to make review easy.

greg k-h