linux-kernel - Re: [PATCH v2] HID: google: modify HID device groups of eel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm>
Date:   Fri, 14 Jan 2022 09:38:23 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, dianders@...gle.com,
        Wei-Ning Huang <wnhuang@...gle.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Sean O'Brien <seobrien@...omium.org>
Subject: Re: [PATCH v2] HID: google: modify HID device groups of eel

On Fri, 7 Jan 2022, Zhengqiao Xia wrote:

> If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet
> Mode Switch of eel hammer will not be detected by system. when it
> is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet
> Mode Switch successfully.
> 
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
> ---
>  drivers/hid/hid-google-hammer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 0403beb3104b..e5acd15f4a55 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
>  static const struct hid_device_id hammer_devices[] = {
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
> -	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,

Color me confused, but anything with HID_GROUP_VIVALDI should be matched 
by hid-vivaldi driver, so what is this about?

Adding some more CCs.

Thanks,

-- 
Jiri Kosina
SUSE Labs