linux-kernel - Re: [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33e93f72-0d5a-b624-f58e-c35155bbda1e@amd.com>
Date:   Fri, 14 Jan 2022 09:40:54 +0100
From:   Christian König <christian.koenig@....com>
To:     Guchun Chen <guchun.chen@....com>, peterz@...radead.org,
        mingo@...hat.com, will@...nel.org, longman@...hat.com,
        boqun.feng@...il.com, linux-kernel@...r.kernel.org,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] locking/rwsem: drop redundant semicolon of
 down_write_nest_lock

Am 14.01.22 um 09:37 schrieb Guchun Chen:
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@....com>

Acked-by: Christian König <christian.koenig@....com>

Peter any objections that we push this upstream through the drm subsystem?

Thanks,
Christian.

> ---
>   include/linux/rwsem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index f9348769e558..efa5c324369a 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
>   do {								\
>   	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
>   	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
> -} while (0);
> +} while (0)
>   
>   /*
>    * Take/release a lock when not the owner will release it.