lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 14 Jan 2022 08:10:08 +0800
From:   davidcomponentone@...il.com
To:     davidcomponentone@...il.com
Cc:     linux-kernel@...r.kernel.org, Yang Guang <yang.guang5@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH] tools lib traceevent: fix boolreturn.cocci warning

From: Yang Guang <yang.guang5@....com.cn>

The coccinelle report
./tools/lib/traceevent/event-parse-api.c:289:8-9:
WARNING: return of 0/1 in function 'tep_is_local_bigendian'
with return type bool.

Return statements in functions returning bool should use true/false
instead of 1/0.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Yang Guang <yang.guang5@....com.cn>
Signed-off-by: David Yang <davidcomponentone@...il.com>
---
 tools/lib/traceevent/event-parse-api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/event-parse-api.c b/tools/lib/traceevent/event-parse-api.c
index f8361e45d446..f153476f39c1 100644
--- a/tools/lib/traceevent/event-parse-api.c
+++ b/tools/lib/traceevent/event-parse-api.c
@@ -286,7 +286,7 @@ bool tep_is_local_bigendian(struct tep_handle *tep)
 {
 	if (tep)
 		return (tep->host_bigendian == TEP_BIG_ENDIAN);
-	return 0;
+	return false;
 }
 
 /**
-- 
2.30.2

Powered by blists - more mailing lists