linux-kernel - Re: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfxtGue7bbMm_MU2GWwWo4aZLW2Pj_U9ocCQmWr6wfGMw@mail.gmail.com>
Date:   Fri, 14 Jan 2022 11:46:04 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Wells Lu 呂芳騰 <wells.lu@...plus.com>
Cc:     Wells Lu <wellslutw@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "dvorkin@...bo.com" <dvorkin@...bo.com>
Subject: Re: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021

On Fri, Jan 14, 2022 at 4:51 AM Wells Lu 呂芳騰 <wells.lu@...plus.com> wrote:

...

> > > > > > > +       bool "Sunplus SP7021 PinMux and GPIO driver"
> > > > > >
> > > > > > Why bool and not tristate?
> > > > >
> > > > > Pinctrl driver is selected by many drivers in SP7021 platform.
> > > > > We never build it as a module, but build-in to kernel.
> > > > > So we use "bool".
> > > > >
> > > > > Should we set it to tristate?
> > > >
> > > > You still haven't answered "why", so I can't tell you.
> > >
> > > I am puzzled because I think I have answered "why".
> >
> > Nope. :-)
> >
> > > Because Pinctrl driver is necessary for all SP7021-based platforms.
> >
> > "Why?" Why is it necessary (to be built-in)?
>
> Pinctrl is necessary to be built-in because drivers of boot-device,
> like eMMC, SD card, NAND flash, and NOR flash drivers, need it.
>
> SP7021 supports booting from eMMC, SD card, NAND flash and NOR flash
> devices. Their drivers need Pinctrl driver probes in advance.

On x86 platforms, for example, booting from eMMC and SD card does not
require a pin control driver to be built-in. Why is this requirement
for SP platforms?

-- 
With Best Regards,
Andy Shevchenko