linux-kernel - Re: [PATCH] drm: bridge: it66121: Remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44f2e610-ab69-2c32-8c1d-a9f40aa607f0@baylibre.com>
Date:   Fri, 14 Jan 2022 11:48:52 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Drew Davenport <ddavenport@...omium.org>, ple@...libre.com
Cc:     a.hajda@...sung.com, robert.foss@...aro.org,
        Laurent.pinchart@...asonboard.com, jonas@...boo.se,
        jernej.skrabec@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: it66121: Remove redundant check

On 14/01/2022 07:40, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> Signed-off-by: Drew Davenport <ddavenport@...omium.org>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 06b59b422c69..69288cf894b9 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
>  		return -EPROBE_DEFER;
>  	}
>  
> -	if (!ctx->next_bridge)
> -		return -EPROBE_DEFER;
> -
>  	i2c_set_clientdata(client, ctx);
>  	mutex_init(&ctx->lock);
>  
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>