linux-kernel - Re: [PATCH] btrfs: zoned: Remove redundant initialization of to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db049584-dc23-78ca-9fc7-0d575855b4ed@suse.com>
Date:   Fri, 14 Jan 2022 13:06:04 +0200
From:   Nikolay Borisov <nborisov@...e.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, clm@...com
Cc:     josef@...icpanda.com, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] btrfs: zoned: Remove redundant initialization of to_add



On 14.01.22 г. 12:41, Jiapeng Chong wrote:
> to_add is being initialized to len but this is never read as
> to_add is overwritten later on. Remove the redundant
> initialization.
> 
> Cleans up the following clang-analyzer warning:
> 
> fs/btrfs/extent-tree.c:2769:8: warning: Value stored to 'to_add' during
> its initialization is never read [clang-analyzer-deadcode.DeadStores].

To make it even better it would be good if to_add is define within the
if (!global_rsv->full) branch.

> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  fs/btrfs/extent-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index d89273c4b6b8..37117b62d005 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2766,7 +2766,7 @@ static int unpin_extent_range(struct btrfs_fs_info *fs_info,
>  		spin_unlock(&cache->lock);
>  		if (!readonly && return_free_space &&
>  		    global_rsv->space_info == space_info) {
> -			u64 to_add = len;
> +			u64 to_add;
>  
>  			spin_lock(&global_rsv->lock);
>  			if (!global_rsv->full) {
>